Re: [PATCH 4/9] usb-core: Free bulk streams on interface release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 4 Oct 2013, Hans de Goede wrote:

> Documentation/usb/bulk-streams.txt says:
> 
> All stream IDs will be deallocated when the driver releases the interface, to
> ensure that drivers that don't support streams will be able to use the endpoint
> 
> This commit actually implements this.

> --- a/drivers/usb/core/driver.c
> +++ b/drivers/usb/core/driver.c
> @@ -369,8 +369,9 @@ static int usb_unbind_interface(struct device *dev)
>  {
>  	struct usb_driver *driver = to_usb_driver(dev->driver);
>  	struct usb_interface *intf = to_usb_interface(dev);
> +	struct usb_host_endpoint *ep, *eps[USB_MAXENDPOINTS];

That's a big array to put on the stack: 30 entries each containing 8 
bytes (on a 64-bit arch).

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux