Hi, On Wed, Oct 02, 2013 at 04:15:06PM +0200, Andrzej Pietrasiewicz wrote: > W dniu 01.10.2013 16:53, Felipe Balbi pisze: > >On Thu, Sep 26, 2013 at 02:38:21PM +0200, Andrzej Pietrasiewicz wrote: > >>fsg_common_init is a lengthy function. Now there are helper functions > >>which cover all parts of it. Use them. > >> > >>Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx> > >>Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > > >this patch adds Warnings: > > > >In file included from > >drivers/usb/gadget/mass_storage.c:58:0: > >drivers/usb/gadget/f_mass_storage.c:2646:27: > >warning: 'fsg_common_setup' defined but not used [-Wunused-function] > >In file included from > >linux/drivers/usb/gadget/acm_ms.c:43:0: > >linux/drivers/usb/gadget/f_mass_storage.c:2646:27: > >warning: 'fsg_common_setup' defined but not used [-Wunused-function] > >In file included from > >linux/drivers/usb/gadget/multi.c:44:0: > >linux/drivers/usb/gadget/f_mass_storage.c:2646:27: > >warning: 'fsg_common_setup' defined but not used [-Wunused-function] > > > >I've stopped applying this series. when resending, please rebase on my > >'testing' branch. > > > Hi Felipe, > > I believe these warnings come from the patch #6 in the series; > the patch you are referring to (#7) _is_ actually about _using_ the > fsg_common_setup(). > > I have now distributed the code of the series over the patches in a > different way so that there are no warnings about unused functions. > The new series has an additional benefit of some patches being shorter. > I will be sending the series tomorrow as I would like to do some testing > before I submit it. alright, please rebase on my testing branch (or next) since some of your original patches were already applied. -- balbi
Attachment:
signature.asc
Description: Digital signature
