RE: [PATCH] staging: dwc2: Make dwc2_hw_params.host_channels large enough

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Matthijs Kooijman [mailto:matthijs@xxxxxxxx]
> Sent: Thursday, October 03, 2013 12:35 AM
> 
> > By the way, it looks like 'num_dev_ep' would have the same problem,
> 
> I don't think so, since the hardware doesn't do the off-by-one trick
> there (presumably because having 0 endpoints make sense, but 0 host
> channels doesn't):
> 
>         hw->num_dev_ep = (hwcfg2 & GHWCFG2_NUM_DEV_EP_MASK) >>
>                          GHWCFG2_NUM_DEV_EP_SHIFT;

Yep, you're right, I got it confused with GHWCFG4_NUM_IN_EPS, which we
don't use.

> > That one and also 'num_dev_perio_in_ep' and 'dev_token_q_depth' should
> > be removed, I think.
> 
> Doesn't hurt to keep them around, I think? When device mode is
> implemented, I guess this code will need to present exactly like it is
> now (unlike other device mode code, which likely needs to be adapted to
> whatever s3-hsotg is doing now)?

When we go to move the driver out of staging, I'm pretty sure these
do-nothing parameters will have to be removed.

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux