Hi Oliver,
This patch looks fine, aside from the introduction of trailing
whitespace on the blank line change, which I've fixed.
I'll queue it to Greg shortly.
Thanks,
Sarah Sharp
On Mon, Sep 30, 2013 at 03:50:54PM +0200, oliver@xxxxxxxxxx wrote:
> From: Oliver Neukum <oneukum@xxxxxxx>
>
> It has been reported that this chipset really cannot
> sleep without this extraordinary delay.
>
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>
> ---
> drivers/usb/host/xhci-pci.c | 8 ++++++++
> drivers/usb/host/xhci.c | 9 +++++++--
> drivers/usb/host/xhci.h | 1 +
> 3 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 236c3aa..5444ecd 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -69,6 +69,14 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> "QUIRK: Fresco Logic xHC needs configure"
> " endpoint cmd after reset endpoint");
> }
> + if (pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_PDK &&
> + pdev->revision == 0x4) {
> + xhci->quirks |= XHCI_SLOW_SUSPEND;
> + xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
> + "QUIRK: Fresco Logic xHC revision %u"
> + "must be suspended extra slowly",
> + pdev->revision);
> + }
> /* Fresco Logic confirms: all revisions of this chip do not
> * support MSI, even though some of them claim to in their PCI
> * capabilities.
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 1e36dbb..e9825b9 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -839,6 +839,7 @@ static void xhci_clear_command_ring(struct xhci_hcd *xhci)
> int xhci_suspend(struct xhci_hcd *xhci)
> {
> int rc = 0;
> + unsigned int delay = XHCI_MAX_HALT_USEC;
> struct usb_hcd *hcd = xhci_to_hcd(xhci);
> u32 command;
>
> @@ -850,7 +851,7 @@ int xhci_suspend(struct xhci_hcd *xhci)
> xhci_dbg(xhci, "%s: stopping port polling.\n", __func__);
> clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
> del_timer_sync(&hcd->rh_timer);
> -
> +
> spin_lock_irq(&xhci->lock);
> clear_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
> clear_bit(HCD_FLAG_HW_ACCESSIBLE, &xhci->shared_hcd->flags);
> @@ -861,8 +862,12 @@ int xhci_suspend(struct xhci_hcd *xhci)
> command = xhci_readl(xhci, &xhci->op_regs->command);
> command &= ~CMD_RUN;
> xhci_writel(xhci, command, &xhci->op_regs->command);
> +
> + /* Some chips from Fresco Logic need an extraordinary delay */
> + delay *= (xhci->quirks & XHCI_SLOW_SUSPEND) ? 10 : 1;
> +
> if (xhci_handshake(xhci, &xhci->op_regs->status,
> - STS_HALT, STS_HALT, XHCI_MAX_HALT_USEC)) {
> + STS_HALT, STS_HALT, delay)) {
> xhci_warn(xhci, "WARN: xHC CMD_RUN timeout\n");
> spin_unlock_irq(&xhci->lock);
> return -ETIMEDOUT;
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index 289fbfb..4f82d21 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1548,6 +1548,7 @@ struct xhci_hcd {
> #define XHCI_COMP_MODE_QUIRK (1 << 14)
> #define XHCI_AVOID_BEI (1 << 15)
> #define XHCI_PLAT (1 << 16)
> +#define XHCI_SLOW_SUSPEND (1 << 17)
> unsigned int num_active_eps;
> unsigned int limit_active_eps;
> /* There are two roothubs to keep track of bus suspend info for */
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
