On Thu, 3 Oct 2013, Huang Rui wrote: > Commit "usb: pci-quirks: refactor AMD quirk to abstract AMD chipset types" > introduced a new AMD chipset type to filter AMD platforms with different > chipsets. > > According to a recent thread [1], this patch updates USB subsystem hang > symptom quirk which is observed on AMD all SB600 and SB700 revision > 0x3a/0x3b. And make it use the new chipset type to represent. > > [1] http://marc.info/?l=linux-usb&m=138012321616452&w=2 > > Signed-off-by: Huang Rui <ray.huang@xxxxxxx> > +int usb_amd_hang_symptom_quirk(void) > +{ > + u8 rev; > + > + usb_amd_find_chipset_info(); > + rev = amd_chipset.sb_type.rev; > + /* SB600 and old version of SB700 have hang symptom bug */ > + return (amd_chipset.sb_type.gen == AMD_CHIPSET_SB600 || > + (amd_chipset.sb_type.gen == AMD_CHIPSET_SB700 && > + rev >= 0x3a && rev <= 0x3b)) ? 1 : 0; You don't need the "? 1 : 0" part. When you remove it, change the function's return type to bool. The same comment applies to the other patch in this series. For both patches, when you make this change you can add: Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
