Hi, On Tue, Sep 24, 2013 at 11:47:16AM +0200, Robert Baldyga wrote: > Hello, > > This is update for my proposal for isochronous transfers support in s3c-hsotg > driver. I've fixed issuses pointed by Bartlomiej Zolnierkiewicz. For more > information, please check the change log at the end of the mail. this shouldn't be part of commit log. > This patch adds isochronous transfer support. It adds few modifications: > - Modify s3c_hsotg_write_fifo() function. It actually calculates transfer > size, taking into account Multi Count value, which indicates number of > transactions per microframe. > - Fix s3c_hsotg_start_req() function by setting number of packets to Multi > Count field in DIEPTSIZ register for isochronous endpoints. > - Fix s3c_hsotg_set_ep_maxpacket() function. Field wMaxPacketSize of endpoint > descriptor is now splitted into maximum packet size value and number of > additional transaction per microframe. > - Modify s3c_hsotg_epint() function. Some interrupts are ignored for > isochronous endpoints, (e.g. INTknTXFEmpMsk) becouse isochronous request is > always transfered in single transaction, which ends with XferCompl interrupt. > Add Odd/Even microframe toggle to allow data transfering in each microframe. > - Fix s3c_hsotg_ep_enable() function by supporting isochronous endpoint type. you're doing way too many things in a single patch. > Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > Changelog: > > v2: > - moved bugfix affecting to the other features to separated patch > - changed conditions order in request length checking in s3c_hsotg_start_req > function, as Bartlomiej Zolnierkiewicz suggested > - fixed typos > > v1: https://lkml.org/lkml/2013/9/23/72 > - initial proposal changelog sould be after tearline (---) below. -- balbi
Attachment:
signature.asc
Description: Digital signature
