Re: [PATCH 2/4] usb: musb: add a type to each dma engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Aug 13, 2013 at 07:49:43PM +0200, Sebastian Andrzej Siewior wrote:
> This patch defines four types of current supported DMA engines and
> assignes them to each dma engine. This should get rid of a few ifdefs
> later on.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

I would *really* like to avoid this construct. Mainly because it's
possible to have the same programming model (from MUSB's point of view)
to start a DMA transfer. What I mean is that the correct way to set
[RT]XCSR is the same no matter which engine you're using. For
DMA-specific parts, we already have ->channel_program() abstracting that
out.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux