Hi, On Sat, Sep 28, 2013 at 12:05:34AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > When mounting a gadgetfs the following error message is seen: > > $ modprobe gadgetfs > gadgetfs: USB Gadget filesystem, version 24 Aug 2004 > $ mkdir /dev/gadget > $ mount -t gadgetfs none /dev/gadget > nop ci_hdrc.0: failed to start (null): -120 > > The error comes from gadgetfs_probe(), which returns -EISNAM (-120). > > As Alan Stern explains[1], this is the normal behavior: > > "It is a temporary measure, used only when the file system is set up > initially. The real bind routine is gadgetfs_bind(), which gets called > when userspace configures the gadget. > > In short, this is how it is intended to work. It isn't a bug." > > [1] http://marc.info/?l=linux-usb&m=138029668707075&w=2 > > So in order to prevent the error message, do not report EISNAM as an error. > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> Alan, are you ok with this version ? ps: it's a good practice to Cc people who have been reviewing your patches. > --- > Changes since v1: > - Still treat EISNAM as error. Only discard printing the error message. > > drivers/usb/gadget/udc-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c > index 59891b1..27768a7 100644 > --- a/drivers/usb/gadget/udc-core.c > +++ b/drivers/usb/gadget/udc-core.c > @@ -356,7 +356,8 @@ static int udc_bind_to_driver(struct usb_udc *udc, struct usb_gadget_driver *dri > kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE); > return 0; > err1: > - dev_err(&udc->dev, "failed to start %s: %d\n", > + if (ret != -EISNAM) > + dev_err(&udc->dev, "failed to start %s: %d\n", > udc->driver->function, ret); > udc->driver = NULL; > udc->dev.driver = NULL; > -- > 1.8.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- balbi
Attachment:
signature.asc
Description: Digital signature
