Re: [PATCHv2] staging: dwc2: Fix code that gets the nummber of host channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 30, 2013 at 05:05:23PM -0500, dinguyen@xxxxxxxxxx wrote:
> From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> 
> The variable host_channels of dwc2_hw_params struct is only 4-bits. Adding
> a 1 to a 0xf results in a 0 for host_channels. Thus, the driver was always
> thinking it had 0 host channels.
> 
> Represent the correct number of host channels by using the host_channels
> variable of dwc2_core_params struct. We should do the +1 in
> dwc2_set_param_host_channels();
> 
> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>

Ah.  Good.  You've fixed the compile problem, but I still don't think
you have tested it; there just wasn't enough time.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux