Re: [PATCH 2/2] net: qmi_wwan: fix checkpatch warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Bjørn Mork <bjorn@xxxxxxx>
Date: Wed, 25 Sep 2013 15:31:39 +0200

> Sorry, I really don't see the point of this.  Yes, the lines are longer
> than 80 columns, but breaking them don't improve the readability at
> all.  On the contrary, IMHO.
> 
> So NAK from me for this part.

Sorry, breaking things up like this is what we do everywhere.

It's not strictly 80 columns but "about 80 columns".

And the only place we don't break things up is for messages that end
up in the kernel log.  Those strings can take the line as long as is
reasonably necessary.

But at argument delimiters and operators for long complex expressions,
we break it up so that the lines do not significantly exceed 80
columns.

Anything else is your opinion, and not what we've been trying to do
consistently across the kernel and in particular in the networking.

Therefore this patch is perfectly fine and I intent to apply it.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux