Re: [PATCH] xhci: extra long delay for S4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le Mon, 30 Sep 2013 14:50:12 +0100,
Oliver Neukum <oneukum@xxxxxxx> a écrit :

> On Mon, 2013-09-30 at 05:33 -0700, Greg KH wrote:
> > On Mon, Sep 30, 2013 at 02:25:29PM +0200, oliver@xxxxxxxxxx wrote:
> > > From: Oliver Neukum <oneukum@xxxxxxx>
> > > 
> > > Some controllers really do need much longer than the standard
> > > allows.
> > > 
> > > Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>
> > > ---
> > >  drivers/usb/host/xhci.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> > > index 1e36dbb..8b7589d 100644
> > > --- a/drivers/usb/host/xhci.c
> > > +++ b/drivers/usb/host/xhci.c
> > > @@ -861,8 +861,9 @@ int xhci_suspend(struct xhci_hcd *xhci)
> > >  	command = xhci_readl(xhci, &xhci->op_regs->command);
> > >  	command &= ~CMD_RUN;
> > >  	xhci_writel(xhci, command, &xhci->op_regs->command);
> > > +	/* 1b73:1000 (rev 04) needs a very long timeout */
> > 
> > Any hint on what device this is?
> > 
> > And maybe an extra line before the comment?
> > 
> > How about only doing the delay for specific devices, or is this not
> > a big deal to wait for every device?
> 
> All good points. I am redoing.
> 
> 	Sorry
> 		Oliver
> 
Isn't the delay only a timeout ?

In this case this affect every device only when they are not working
(hit the timeout).


Matthieu
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux