On Mon, Sep 23, 2013 at 8:59 PM, Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote: > Commit 638c5115a7949(USBNET: support DMA SG) introduces DMA SG > if the usb host controller is capable of building packet from > discontinuous buffers, but missed handling padding packet when > building DMA SG. > > This patch attachs the pre-allocated padding packet at the > end of the sg list, so padding packet can be sent to device > if drivers require that. > > Reported-by: David Laight <David.Laight@xxxxxxxxxx> > Acked-by: Oliver Neukum <oliver@xxxxxxxxxx> > Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx> > --- > v1: > - fix bug in case of dev->can_dma_sg and !urb->num_sgs David, could you queue this patch in your tree? And it should fix regression caused by commit 638c5115a7949(USBNET: support DMA SG), since I found that without the padding the device can't send out packets successfully if their length is dividable by max packet size, and the problem can be observed with icmp sending: $ping -s 974 another_machine #from host with ax99179_178a attached Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
