On Fri, Sep 27 2013, Robert Baldyga wrote: > This patch add missing error check in ffs_func_bind() function, after > ffs_do_descs() funcion call for hs descriptors. Without this check it's > possible that the module will try dereference incorrect pointer. > > Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx> Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx> > --- > drivers/usb/gadget/f_fs.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c > index 1a66c5b..fe7d532 100644 > --- a/drivers/usb/gadget/f_fs.c > +++ b/drivers/usb/gadget/f_fs.c > @@ -2264,7 +2264,10 @@ static int ffs_func_bind(struct usb_configuration *c, > data->raw_descs + ret, > (sizeof data->raw_descs) - ret, > __ffs_func_bind_do_descs, func); > + if (unlikely(ret < 0)) > + goto error; > } > + This new line with only a tab in it is not needed here though. > > /* > * Now handle interface numbers allocation and interface and -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>--ooO--(_)--Ooo--
Attachment:
signature.asc
Description: PGP signature
