There are no more old interface users left. Remove it.
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
---
drivers/usb/gadget/f_mass_storage.c | 154 +----------------------------------
drivers/usb/gadget/f_mass_storage.h | 21 -----
2 files changed, 1 insertions(+), 174 deletions(-)
diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
index fb43a49..8700479 100644
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -2642,17 +2642,13 @@ void fsg_common_get(struct fsg_common *common)
{
kref_get(&common->ref);
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_get);
-#endif
void fsg_common_put(struct fsg_common *common)
{
kref_put(&common->ref, fsg_common_release);
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_put);
-#endif
/* check if fsg_num_buffers is within a valid range */
static inline int fsg_num_buffers_validate(unsigned int fsg_num_buffers)
@@ -2690,9 +2686,7 @@ void fsg_common_set_sysfs(struct fsg_common *common, bool sysfs)
{
common->sysfs = sysfs;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_set_sysfs);
-#endif
static void _fsg_common_free_buffers(struct fsg_buffhd *buffhds, unsigned n)
{
@@ -2744,18 +2738,14 @@ error_release:
return -ENOMEM;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_set_num_buffers);
-#endif
void fsg_common_free_buffers(struct fsg_common *common)
{
_fsg_common_free_buffers(common->buffhds, common->fsg_num_buffers);
common->buffhds = NULL;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_free_buffers);
-#endif
int fsg_common_set_nluns(struct fsg_common *common, int nluns)
{
@@ -2781,9 +2771,7 @@ int fsg_common_set_nluns(struct fsg_common *common, int nluns)
return 0;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_set_nluns);
-#endif
void fsg_common_free_luns(struct fsg_common *common)
{
@@ -2791,26 +2779,20 @@ void fsg_common_free_luns(struct fsg_common *common)
kfree(common->luns);
common->luns = NULL;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_free_luns);
-#endif
void fsg_common_set_ops(struct fsg_common *common,
const struct fsg_operations *ops)
{
common->ops = ops;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_set_ops);
-#endif
void fsg_common_set_private_data(struct fsg_common *common, void *priv)
{
common->private_data = priv;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_set_private_data);
-#endif
int fsg_common_set_cdev(struct fsg_common *common,
struct usb_composite_dev *cdev, bool can_stall)
@@ -2840,9 +2822,7 @@ int fsg_common_set_cdev(struct fsg_common *common,
return 0;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_set_cdev);
-#endif
static inline int fsg_common_add_sysfs(struct fsg_common *common,
struct fsg_lun *lun)
@@ -2907,9 +2887,7 @@ void fsg_common_remove_lun(struct fsg_lun *lun, bool sysfs)
kfree(lun->name);
kfree(lun);
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_remove_lun);
-#endif
void _fsg_common_remove_luns(struct fsg_common *common, int n)
{
@@ -2926,9 +2904,7 @@ void fsg_common_remove_luns(struct fsg_common *common)
{
_fsg_common_remove_luns(common, common->nluns);
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_remove_luns);
-#endif
#define MAX_LUN_NAME_LEN 80
@@ -3025,9 +3001,7 @@ error_name:
kfree(lun);
return rc;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_create_lun);
-#endif
int fsg_common_create_luns(struct fsg_common *common, struct fsg_config *cfg)
{
@@ -3049,9 +3023,7 @@ fail:
_fsg_common_remove_luns(common, i);
return rc;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_create_luns);
-#endif
void fsg_common_set_inquiry_string(struct fsg_common *common, const char *vn,
const char *pn)
@@ -3068,9 +3040,7 @@ void fsg_common_set_inquiry_string(struct fsg_common *common, const char *vn,
: "File-Stor Gadget"),
i);
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_set_inquiry_string);
-#endif
int fsg_common_run_thread(struct fsg_common *common)
{
@@ -3089,66 +3059,7 @@ int fsg_common_run_thread(struct fsg_common *common)
return 0;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_common_run_thread);
-#endif
-
-struct fsg_common *fsg_common_init(struct fsg_common *common,
- struct usb_composite_dev *cdev,
- struct fsg_config *cfg)
-{
- int rc;
-
- common = fsg_common_setup(common, !!common);
- if (IS_ERR(common))
- return common;
- common->sysfs = true;
- common->state = FSG_STATE_IDLE;
-
- rc = fsg_common_set_num_buffers(common, cfg->fsg_num_buffers);
- if (rc) {
- if (common->free_storage_on_release)
- kfree(common);
- return ERR_PTR(rc);
- }
-
- fsg_common_set_ops(common, cfg->ops);
- fsg_common_set_private_data(common, cfg->private_data);
-
- rc = fsg_common_set_cdev(common, cdev, cfg->can_stall);
- if (rc)
- goto error_release;
-
- rc = fsg_common_set_nluns(common, cfg->nluns);
- if (rc)
- goto error_release;
-
- rc = fsg_common_create_luns(common, cfg);
- if (rc)
- goto error_release;
-
-
- fsg_common_set_inquiry_string(common, cfg->vendor_name,
- cfg->product_name);
-
- /* Information */
- INFO(common, FSG_DRIVER_DESC ", version: " FSG_DRIVER_VERSION "\n");
-
- rc = fsg_common_run_thread(common);
- if (rc)
- goto error_release;
-
- return common;
-
-error_release:
- common->state = FSG_STATE_TERMINATED; /* The thread is dead */
- /* Call fsg_common_release() directly, ref might be not initialised. */
- fsg_common_release(&common->ref);
- return ERR_PTR(rc);
-}
-#ifndef USB_FMS_INCLUDED
-EXPORT_SYMBOL(fsg_common_init);
-#endif
static void fsg_common_release(struct kref *ref)
{
@@ -3199,9 +3110,8 @@ static int fsg_bind(struct usb_configuration *c, struct usb_function *f)
struct usb_ep *ep;
unsigned max_burst;
int ret;
-
-#ifndef USB_FMS_INCLUDED
struct fsg_opts *opts;
+
opts = container_of(f->fi, struct fsg_opts, func_inst);
if (!opts->no_configfs) {
ret = fsg_common_set_cdev(fsg->common, c->cdev,
@@ -3213,7 +3123,6 @@ static int fsg_bind(struct usb_configuration *c, struct usb_function *f)
if (ret)
return ret;
}
-#endif
fsg->gadget = gadget;
@@ -3268,63 +3177,6 @@ autoconf_fail:
/****************************** ALLOCATE FUNCTION *************************/
-#ifdef USB_FMS_INCLUDED
-
-static void old_fsg_unbind(struct usb_configuration *c, struct usb_function *f)
-{
- struct fsg_dev *fsg = fsg_from_func(f);
- struct fsg_common *common = fsg->common;
-
- DBG(fsg, "unbind\n");
- if (fsg->common->fsg == fsg) {
- fsg->common->new_fsg = NULL;
- raise_exception(fsg->common, FSG_STATE_CONFIG_CHANGE);
- /* FIXME: make interruptible or killable somehow? */
- wait_event(common->fsg_wait, common->fsg != fsg);
- }
-
- fsg_common_put(common);
- usb_free_all_descriptors(&fsg->function);
- kfree(fsg);
-}
-
-static int fsg_bind_config(struct usb_composite_dev *cdev,
- struct usb_configuration *c,
- struct fsg_common *common)
-{
- struct fsg_dev *fsg;
- int rc;
-
- fsg = kzalloc(sizeof *fsg, GFP_KERNEL);
- if (unlikely(!fsg))
- return -ENOMEM;
-
- fsg->function.name = FSG_DRIVER_DESC;
- fsg->function.bind = fsg_bind;
- fsg->function.unbind = old_fsg_unbind;
- fsg->function.setup = fsg_setup;
- fsg->function.set_alt = fsg_set_alt;
- fsg->function.disable = fsg_disable;
-
- fsg->common = common;
- /*
- * Our caller holds a reference to common structure so we
- * don't have to be worry about it being freed until we return
- * from this function. So instead of incrementing counter now
- * and decrement in error recovery we increment it only when
- * call to usb_add_function() was successful.
- */
-
- rc = usb_add_function(c, &fsg->function);
- if (unlikely(rc))
- kfree(fsg);
- else
- fsg_common_get(fsg->common);
- return rc;
-}
-
-#else
-
static inline struct fsg_lun_opts *to_fsg_lun_opts(struct config_item *item)
{
return container_of(to_config_group(item), struct fsg_lun_opts, group);
@@ -3794,8 +3646,6 @@ DECLARE_USB_FUNCTION_INIT(mass_storage, fsg_alloc_inst, fsg_alloc);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Michal Nazarewicz");
-#endif
-
/************************* Module parameters *************************/
@@ -3831,7 +3681,5 @@ void fsg_config_from_params(struct fsg_config *cfg,
cfg->can_stall = params->stall;
cfg->fsg_num_buffers = fsg_num_buffers;
}
-#ifndef USB_FMS_INCLUDED
EXPORT_SYMBOL(fsg_config_from_params);
-#endif
diff --git a/drivers/usb/gadget/f_mass_storage.h b/drivers/usb/gadget/f_mass_storage.h
index 62b4b8f..a16c2a9 100644
--- a/drivers/usb/gadget/f_mass_storage.h
+++ b/drivers/usb/gadget/f_mass_storage.h
@@ -122,10 +122,6 @@ void fsg_common_get(struct fsg_common *common);
void fsg_common_put(struct fsg_common *common);
-struct fsg_common *fsg_common_init(struct fsg_common *common,
- struct usb_composite_dev *cdev,
- struct fsg_config *cfg);
-
void fsg_common_set_sysfs(struct fsg_common *common, bool sysfs);
int fsg_common_set_num_buffers(struct fsg_common *common, unsigned int n);
@@ -163,21 +159,4 @@ void fsg_config_from_params(struct fsg_config *cfg,
const struct fsg_module_parameters *params,
unsigned int fsg_num_buffers);
-static inline struct fsg_common *
-fsg_common_from_params(struct fsg_common *common,
- struct usb_composite_dev *cdev,
- const struct fsg_module_parameters *params,
- unsigned int fsg_num_buffers)
- __attribute__((unused));
-static inline struct fsg_common *
-fsg_common_from_params(struct fsg_common *common,
- struct usb_composite_dev *cdev,
- const struct fsg_module_parameters *params,
- unsigned int fsg_num_buffers)
-{
- struct fsg_config cfg;
- fsg_config_from_params(&cfg, params, fsg_num_buffers);
- return fsg_common_init(common, cdev, &cfg);
-}
-
#endif /* USB_F_MASS_STORAGE_H */
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
