Not a comment on the code, just your text: On Wed, Sep 25, 2013 at 11:53:00AM +0200, Andrew Lunn wrote: > Add a driver which supports the following Moxa USB to serial converters: > * 2 ports : UPort 1250, UPort 1250I > * 4 ports : UPort 1410, UPort 1450, UPort 1450I > * 8 ports : UPort 1610-8, UPort 1650-8 > * 16 ports : UPort 1610-16, UPort 1650-16 > > The UPORT devices don't directy fit the USB serial model. USB serial > assumes a bulk in/out endpoint pair per serial port. Thus a dual port > USB serial device is expected to have two bulk in/out pairs. The Moxa > UPORT only has one pair for data transfer and places a header on each > transfer over the endpoint indicating for which port the transfer > relates to. There is a second endpoint pair for events, just as modem > control lines changing state, setting baud rates etc. Again, a > multiplexing header is used on these endpoints. > > This difference to the model results in some additional code which > other drivers don't have: The second (or was it the third?) usb serial driver in the kernel had this same type of architecture, the io-edgeport driver. It's nothing new (been around since the 1990's), and the usb-serial core supports it just fine. So it's not like we aren't very used to this type of a device :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
