On Tue, Sep 24, 2013 at 10:21:32AM -0400, Alan Stern wrote:
> On Tue, 24 Sep 2013, Huang Rui wrote:
>
> > Hi Sarah and Alan,
> >
> > On Mon, Sep 23, 2013 at 05:14:02PM -0700, Sarah Sharp wrote:
> > > On Mon, Sep 23, 2013 at 12:43:15PM -0400, Alan Stern wrote:
> > > > This version of the patch set looks good.
> > > >
> > > > Alan Stern
> > >
> > > Looks fine to me as well.
> > >
> > > Acked-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> > >
> >
> > Thank you for acked-by :)
> > Would I better use new chipset type intead of filtering with revision
> > by hand for special generation in old AMD xhci/ehci/ohci quirks. If
> > OK, I will do this work after the quirk is applied.
>
> I think the patch is probably okay as it stands. The chipset type and
> revision values in the code should match the names chosen by the
> manufacturer.
>
Yes, the patch set refactors chipset type for AMD chipset
genernations, this type is appropriate for all AMD platforms including
the previous.
For example, below quirk for amd700 with SB800 chipsets, actually I
can only use: amd_chipset.sb_type.gen == AMD_CHIPSET_SB800 in
pci-quirks.c instead.
static int ohci_quirk_amd700(struct usb_hcd *hcd)
{
...
amd_smbus_dev = pci_get_device(PCI_VENDOR_ID_ATI,
PCI_DEVICE_ID_ATI_SBX00_SMBUS, NULL);
if (!amd_smbus_dev)
return 0;
rev = amd_smbus_dev->revision;
/* SB800 needs pre-fetch fix */
if ((rev >= 0x40) && (rev <= 0x4f)) {
ohci->flags |= OHCI_QUIRK_AMD_PREFETCH;
ohci_dbg(ohci, "enabled AMD prefetch quirk\n");
}
pci_dev_put(amd_smbus_dev);
amd_smbus_dev = NULL;
...
}
So I mean whether I should do this updates for old AMD quirks in
future after this patch set is applied.
Thanks,
Rui
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
