On Mon, 23 Sep 2013, Bjorn Helgaas wrote:
> d010e5769 ("PCI / ACPI: Use dev_dbg() instead of dev_info() in
> acpi_pci_set_power_state()") might be part of the solution. That was
> done in response to https://bugzilla.kernel.org/show_bug.cgi?id=60636,
> which looks basically the same as your complaint.
>
> But if we are indeed polling every two seconds, even a dev_dbg() seems
> like overkill to me. Rafael or Lan can probably provide a better
> answer here.
>
> As for the "setting latency timer" messages, I really doubt those are
> useful to anybody. If nobody objects, I'll just drop it, e.g.:
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index b821a62..55a947b 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -2854,7 +2854,7 @@ void __weak pcibios_set_master(struct pci_dev *dev)
> lat = pcibios_max_latency;
> else
> return;
> - dev_printk(KERN_DEBUG, &dev->dev, "setting latency timer to %d\n", lat);
> +
> pci_write_config_byte(dev, PCI_LATENCY_TIMER, lat);
> }
No objection from me.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
