Hi, On Mon, Sep 23, 2013 at 02:23:33PM -0700, Paul Zimmerman wrote: > In dwc2_assign_and_init_hc(), validate urb->actual_length for OUT > endpoints before using the value. This fix is from the Synopsys > vendor driver. > > Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx> > --- > drivers/staging/dwc2/hcd.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c > index da0d35c..b245405 100644 > --- a/drivers/staging/dwc2/hcd.c > +++ b/drivers/staging/dwc2/hcd.c > @@ -780,6 +780,10 @@ static void dwc2_assign_and_init_hc(struct dwc2_hsotg *hsotg, > chan->data_pid_start = qh->data_toggle; > chan->multi_count = 1; > > + if ((urb->actual_length < 0 || urb->actual_length > urb->length) && > + !dwc2_hcd_is_pipe_in(&urb->pipe_info)) > + urb->actual_length = urb->length; weird, why would actual_length be less than zero or greather than urb->length ? I guess you need some more "meat" in your commit log. -- balbi
Attachment:
signature.asc
Description: Digital signature
