Re: [RFC 10/21] xhci: replace xhci_readl() with readl() in xhci-dbg.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 19, 2013 at 2:37 PM, Sarah Sharp
<sarah.a.sharp@xxxxxxxxxxxxxxx> wrote:
> On Fri, Sep 13, 2013 at 03:50:48PM +0530, Pratyush Anand wrote:
>> On Fri, Sep 13, 2013 at 3:40 PM, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>wrote:
>> > Nope :). There is still Kumar 's patch that keeps the wrappers, so it can
>> > be applied instead of mine. But you did not tell me which tool you use
>> > currently to log the mmio operations? it is useful to know.
>> >
>> >
>> Sorry, I did not use any standard tool, rather I made local changes in
>> dwc3_readl and dwc3_writel to log all dwc3 specific read/write
>> operations into a static array, which was dumped to a text file using
>> an ARM debugger (trace32) for further analysis.
>
> Would it be helpful to add a trace event for xHCI register reads and
> writes (but not a debug statement)?  That way you wouldn't have to
> change or recompile the kernel at all, but you could use the trace
> events infrastructure to enable xHCI register read/write debugging.  We
> wouldn't flood log files with register reads and writes, but a trace
> event makes sense.
>
> AFAIK, trace events work on both x86 and ARM.
>

We do have generic mmiotrace if somebody wanted to get a log of all
xhci mmio operations.  So, I don't think xhci specific infrastructure
is needed.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux