On Fri, 13 Sep 2013, Bjorn Helgaas wrote:
> After 9ad3d6ccf5 ("USB: Remove USB private semaphore"), usb_disconnect()
> no longer acquires usb_bus_list_lock, so remove the comment to that effect.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> ---
> drivers/usb/core/hub.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 558313d..dcb8721 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -2006,8 +2006,6 @@ static void hub_free_dev(struct usb_device *udev)
> * Something got disconnected. Get rid of it and all of its children.
> *
> * If *pdev is a normal device then the parent hub must already be locked.
> - * If *pdev is a root hub then this routine will acquire the
> - * usb_bus_list_lock on behalf of the caller.
It would be better to change the comment to say that the caller must
hold the usb_bus_list_lock because that lock protects the set of root
hubs as well as the list of buses.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
