Re: [PATCH v3 3/4] usb: xhci: implement AMD remote wakeup quirk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 07, 2013 at 05:03:52AM +0800, Sarah Sharp wrote:
> On Fri, Sep 06, 2013 at 02:02:04PM -0700, Sarah Sharp wrote:
> > On Fri, Sep 06, 2013 at 06:24:43PM +0800, Huang Rui wrote:
> > > The following patch is required to resolve remote wake issues with
> > > certain devices.
> > > 
> > > Issue description:
> > > If the remote wake is issued from the device in a specific timing
> > > condition while the system is entering sleep state then it may cause
> > > system to auto wake on subsequent sleep cycle.
> > > 
> > > Root cause:
> > > Host controller rebroadcasts the Resume signal > 100 µseconds after
> > > receiving the original resume event from the device. For proper
> > > function, some devices may require the rebroadcast of resume event
> > > within the USB spec of 100µS.
> > > 
> > > Workaroud:
> > > 1. Filter the special platforms, then judge of all the usb devices are
> > > mouse or not. And get out the port id which attached a mouse with Pixart
> > > controller.
> > > 2. Then reset the port which attached issue device during system resume
> > > from S3.
> > 
> > Why are you doing this in the xHCI driver?  You're resetting a device
> > from the host controller driver without letting the USB core know about
> > it?  That seems like a bad idea.
> 
> Ok, I see Alan has already suggested an alternative way to do this in
> the USB core.  Please follow his suggestion.
> 

OK, will do it in v4.

Thanks,
Rui

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux