On Tue, Sep 10, 2013 at 03:34:39PM +0800, Peter Chen wrote:
> There is a pending TD which is not freed after request finishes,
> we do this due to a controller bug. This TD needs to be freed when
> the driver is removed. It prints below error message when unload
> chipidea driver at current code:
> "ci_hdrc ci_hdrc.0: dma_pool_destroy ci_hw_td, b0001000 busy"
> It indicates the buffer at dma pool are still in use.
>
> This commit will free the pending TD at driver's removal procedure,
> it can fix the problem described above.
>
> Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> ---
> drivers/usb/chipidea/udc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 2ea5871..b157c95 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1604,6 +1604,8 @@ static void destroy_eps(struct ci_hdrc *ci)
> for (i = 0; i < ci->hw_ep_max; i++) {
> struct ci_hw_ep *hwep = &ci->ci_hw_ep[i];
>
> + if (hwep->pending_td)
> + free_pending_td(hwep);
> dma_pool_free(ci->qh_pool, hwep->qh.ptr, hwep->qh.dma);
> }
> }
> --
> 1.7.1
Acked-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
