Re: [RFC v3 14/18] xhci: replace 'xhci->cmd_ring->dequeue' with 'trb' in stop_ep cmd handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 23, 2013 at 11:15:14AM +0300, Xenia Ragiadakou wrote:
> This patch replaces 'xhci->cmd_ring->dequeue' with 'trb', the address of
> the command TRB, since it is available to reduce line length.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>

Acked-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/host/xhci-ring.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 60cf547..7a58095 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -769,10 +769,8 @@ static void xhci_handle_cmd_stop_ep(struct xhci_hcd *xhci,
>  
>  	struct xhci_dequeue_state deq_state;
>  
> -	if (unlikely(TRB_TO_SUSPEND_PORT(
> -			     le32_to_cpu(xhci->cmd_ring->dequeue->generic.field[3])))) {
> -		slot_id = TRB_TO_SLOT_ID(
> -			le32_to_cpu(xhci->cmd_ring->dequeue->generic.field[3]));
> +	if (unlikely(TRB_TO_SUSPEND_PORT(le32_to_cpu(trb->generic.field[3])))) {
> +		slot_id = TRB_TO_SLOT_ID(le32_to_cpu(trb->generic.field[3]));
>  		virt_dev = xhci->devs[slot_id];
>  		if (virt_dev)
>  			handle_cmd_in_cmd_wait_list(xhci, virt_dev,
> -- 
> 1.8.3.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux