On Tue, Sep 03, 2013 at 10:34:56AM +0800, Huang Rui wrote:
> Please apply this patch based my last patch, and have a test again.
>
> 8<-------------------------- cut here ----------------------------
>
> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
> index f2e57a1..61a9532 100644
> --- a/drivers/usb/host/xhci-mem.c
> +++ b/drivers/usb/host/xhci-mem.c
> @@ -493,6 +493,9 @@ struct xhci_ring *xhci_stream_id_to_ring(
> {
> struct xhci_virt_ep *ep = &dev->eps[ep_index];
>
> + if (!ep)
> + return NULL;
> +
> if (stream_id == 0)
> return ep->ring;
> if (!ep->stream_info)
Hi Huang,
The real question here is *why* is the endpoint NULL? *Why* is the slot
ID invalid? *Why* are these functions getting called with invalid
information? We need to figure out the root cause, not put in some
band-aid fixes to work around kernel oopses.
Please Cc me on all RFC patches for the xHCI driver. If you see a bug
report for the xHCI driver, and I'm not on Cc, please add me. I don't
mind if you try to triage and fix the bug, but I do want to know when
the xHCI driver has issues.
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
