Re: [RFC v3 09/18] xhci: remove unused 'ep_ring' variable in handle_cmd_completion()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Good catch!  This looks fine.

Sarah

On Fri, Aug 23, 2013 at 11:15:09AM +0300, Xenia Ragiadakou wrote:
> This patch removes the variable 'ep_ring' that is assigned in
> TRB_CONFIG_EP switch case but never used.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> ---
>  drivers/usb/host/xhci-ring.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 0f571c5..beeee96 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1448,7 +1448,6 @@ static void handle_cmd_completion(struct xhci_hcd *xhci,
>  	struct xhci_input_control_ctx *ctrl_ctx;
>  	struct xhci_virt_device *virt_dev;
>  	unsigned int ep_index;
> -	struct xhci_ring *ep_ring;
>  	unsigned int ep_state;
>  
>  	cmd_dma = le64_to_cpu(event->cmd_trb);
> @@ -1522,7 +1521,6 @@ static void handle_cmd_completion(struct xhci_hcd *xhci,
>  				ep_index != (unsigned int) -1 &&
>  		    le32_to_cpu(ctrl_ctx->add_flags) - SLOT_FLAG ==
>  		    le32_to_cpu(ctrl_ctx->drop_flags)) {
> -			ep_ring = xhci->devs[slot_id]->eps[ep_index].ring;
>  			ep_state = xhci->devs[slot_id]->eps[ep_index].ep_state;
>  			if (!(ep_state & EP_HALTED))
>  				goto bandwidth_change;
> -- 
> 1.8.3.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux