On 08/29/2013 08:53 PM, Greg KH wrote:
On Thu, Aug 29, 2013 at 08:37:57PM +0300, Xenia Ragiadakou wrote:
In usb_reset_and_verify_device(), hub_port_init() allocates a new bos
descriptor to hold the value read by the device. The new bos descriptor
has to be compared with the old one in order to figure out if device 's
firmware has changed in which case the device has to be reenumerated.
In the original code, none of the two descriptors was deallocated leading
to memory leaks.
This patch compares the old bos descriptor with the new one to detect change
in firmware and releases the newly allocated bos descriptor to prevent memory
leak.
Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Shouldn't there be a "Reported-by:" and "Tested-by:" field here as well?
thanks,
greg k-h
Do you mean i need to add, under the signed-off,
Reported-by: Martin MOKREJŠ <mmokrejs@xxxxxxxxx>
Tested-by: Martin MOKREJŠ <mmokrejs@xxxxxxxxx>
and resend as PATCH v2 or just PATCH?
Also does it need a
Reviewed-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> ?
ksenia
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
