On Wed, Aug 28, 2013 at 10:50:31AM -0700, Sarah Sharp wrote: > Any objections to queuing this patch through Greg's usb-next tree? I've > already sent the 2/2 patch, which will cause build breakage without this > patch. > > Changes since v2: > - Fixed a checkpatch warning caused by a comment in a macro. > > Sarah Sharp > > >8----------------------------------------------------------------8< > > From: Dmitry Kasatkin <d.kasatkin@xxxxxxxxxxx> > > When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data > structures even when CONFIG_DYNAMIC_DEBUG is not defined. > It leads to build break. > For example, when I try to use dev_dbg_ratelimited in USB code and > CONFIG_USB_DEBUG is enabled, but CONFIG_DYNAMIC_DEBUG is not, I get: > > CC [M] drivers/usb/host/xhci-ring.o > drivers/usb/host/xhci-ring.c: In function ‘xhci_queue_intr_tx’: > drivers/usb/host/xhci-ring.c:3059:3: error: implicit declaration of function ‘DEFINE_DYNAMIC_DEBUG_METADATA’ [-Werror=implicit-function-declaration] > drivers/usb/host/xhci-ring.c:3059:3: error: ‘descriptor’ undeclared (first use in this function) > drivers/usb/host/xhci-ring.c:3059:3: note: each undeclared identifier is reported only once for each function it appears in > drivers/usb/host/xhci-ring.c:3059:3: error: implicit declaration of function ‘__dynamic_pr_debug’ [-Werror=implicit-function-declaration] > drivers/usb/host/xhci-ring.c: In function ‘xhci_queue_isoc_tx_prepare’: > drivers/usb/host/xhci-ring.c:3847:3: error: ‘descriptor’ undeclared (first use in this function) > cc1: some warnings being treated as errors > make[2]: *** [drivers/usb/host/xhci-ring.o] Error 1 > make[1]: *** [drivers/usb/host] Error 2 > make: *** [drivers/usb/] Error 2 > > This patch separates definition for CONFIG_DYNAMIC_DEBUG and DEBUG cases. > > [Note, Sarah moved the comment above the macro to avoid checkpatch > warnings.] > > Signed-off-by: Dmitry Kasatkin <d.kasatkin@xxxxxxxxxxx> > Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
