On Wed, Aug 28, 2013 at 7:24 PM, Dmitry Kasatkin <d.kasatkin@xxxxxxxxxxx> wrote: > On 28/08/13 19:59, Sarah Sharp wrote: >> Please trim your replies. >> >> On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: >>>>>> That change seems to cause the problems: >>>>>> >>>>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f >>>>>> "xhci:prevent "callbacks suppressed" when debug is not enabled" >>>>>> >>>>>> - Sedat - >>>>>> >>>>>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f >>>>>> >>>>> Hello, >>>>> >>>>> [PATCHv2 1/2] was not applied before. >>>>> I pointed this out few hours ago... >> So commit 0730d52a86919300a39a2be37f6c140997dfb82f 'xhci:prevent >> "callbacks suppressed" when debug is not enabled' needed to be applied >> after your first patch? And basically applying that patch alone breaks >> the build? > > Right... > May be I had to stress it somehow... sorry. > Still noone answered me why "drivers/usb/host/xhci-ring.c" does NOT include <linux/device.h> (dev_info_ratelimited() and other defines). I am expecting that... even I see... drivers/usb/host/.xhci-ring.o.cmd:715: include/linux/device.h \ ...where I don't know why this happens. ( For me this is a bit more important than """trimming""" my responses, I keep the history... ) - Sedat - P.S.: List of includes in xhci-ring.c $ grep ^'#include' -nr drivers/usb/host/xhci-ring.c 67:#include <linux/scatterlist.h> 68:#include <linux/slab.h> 69:#include "xhci.h" 70:#include "xhci-trace.h" >> Ugh. Sorry about this. Greg, how do you want to handle this? >> >> Sarah "needs a vacation" Sharp >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
