Re: [PATCH] drivers/usb/gadget/g_ffs.c: add missing header "u_ether.h"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 Aug 2013 08:57:28 +0300
Sergei Trofimovich <slyfox@xxxxxxxxxx> wrote:

> In some .config modes [1] macro 'USB_ETHERNET_MODULE_PARAMETERS'
> gets used without declaration:
> 
>     drivers/usb/gadget/g_ffs.c:79: warning: data definition has no type or storage class
>     drivers/usb/gadget/g_ffs.c:79: warning: type defaults to 'int' in declaration of 'USB_ETHERNET_MODULE_PARAMETERS'
>     drivers/usb/gadget/g_ffs.c:79: warning: function declaration isn't a prototype
> 
> [1]: https://lists.01.org/pipermail/kbuild-all/2013-August/001034.html
> 
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Sergei Trofimovich <slyfox@xxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: Greg KH <greg@xxxxxxxxx>
> ---
>  drivers/usb/gadget/g_ffs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/g_ffs.c b/drivers/usb/gadget/g_ffs.c
> index 5327c82..8f8e2af 100644
> --- a/drivers/usb/gadget/g_ffs.c
> +++ b/drivers/usb/gadget/g_ffs.c
> @@ -13,6 +13,9 @@
>  #define pr_fmt(fmt) "g_ffs: " fmt
>  
>  #include <linux/module.h>
> +
> +#include "u_ether.h"
> +
>  /*
>   * kbuild is not very cooperative with respect to linking separately
>   * compiled library objects into one module.  So for now we won't use
> @@ -37,7 +40,6 @@
>  #    include "f_rndis.c"
>  #    include "rndis.h"
>  #  endif
> -#  include "u_ether.h"
>  
>  static u8 gfs_host_mac[ETH_ALEN];
>  static struct eth_dev *the_dev;
> -- 
> 1.8.3.2
> 
> 

Please, ignore it. It's broken even on allmodconfig:
In file included from drivers/usb/gadget/g_ffs.c:40:0:
    drivers/usb/gadget/f_rndis.c:851:1: error: redefinition of 'rndis_bind_config_vendor'
In file included from drivers/usb/gadget/g_ffs.c:17:0:
    drivers/usb/gadget/u_ether.h:284:1: note: previous definition of 'rndis_bind_config_vendor' was here

-- 

  Sergei

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux