Re: [RFC v3 17/18] xhci: add label 'update_ring' in handle_cmd_completion()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/23/2013 04:19 PM, Sergei Shtylyov wrote:
Hello.

On 23-08-2013 12:15, Xenia Ragiadakou wrote:

This patch adds the label 'update_ring' for the common code path:
inc_deq(xhci, xhci->cmd_ring);
return;

Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
---
  drivers/usb/host/xhci-ring.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index e13531f..03f65dc 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xcorrect ithci-ring.c
[...]
@@ -1567,7 +1565,9 @@ static void handle_cmd_completion(struct xhci_hcd *xhci,
          xhci->error_bitmask |= 1 << 6;
          break;
      }
+update_ring:
      inc_deq(xhci, xhci->cmd_ring);
+    return;

   *return* not needed here, at end of function.

  }

WBR, Sergei

Hi Sergei,

Yes, you are right. Thx! I will wait Sarah to review the patchset and i will send another version
to fix this. If you have any other suggestions, please let me know :)

best regards,
ksenia
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux