In the course of adapting the USBIP tools to our project, I added a few features: * Specify USBIP TCP/IP port number for 'usbip' and 'usbipd' * Request that 'usbipd' write its process id to a file I did some minor cleaning along the way: checkpatch before any of my changes, then going back and repairing alignments broken while adding new options. Finally, the "log" option was not properly accepted by 'usbip'. Greg KH suggested that we drop the PID support from usbipd, arguing that tracking pids should be the responsibility of the initscripts etc. This would imply that we remove all daemonization support, which I'm hesitant to do. I found only two other uses of 'daemon(3)' in the kernel codebase: tools/hv/hv_kvp_daemon.c tools/hv/hv_vss_daemon.c Both of these call 'daemon' then report their PID via syslog, so it seems they're splitting the difference. So long as we have user-space daemons in the kernel codebase, I would like to keep the pid-file method of providing an unambiguous, easy-to-find, and easy-to-parse daemon pid. This patchset is based off: linux-next commit 1e712b0818569846d6b926ecb6bf32b3dea73609 (which is tag next-20130816) Version 2 thread at this URL: http://www.spinics.net/lists/linux-usb/msg92414.html Changes from v2 -> v3: * Downcase USBIP_PORT and friends, since they're no longer constants. Original thread at these urls: http://markmail.org/thread/6re24e7r443kn2nj http://www.mail-archive.com/linux-usb@xxxxxxxxxxxxxxx/msg23959.html Changes from v1 -> v2: * Use "-t" / "--tcp-port" instead of "-p" / "--port"; the 'usbip' command already has a "-p" option for the usbip port in use. * Make sure that 'usbipd' records its PID *after* daemonizing. * Drop first three patches from v1 (they're already accepted). Anthony Foiani (4): staging: usbip: add "-P" / "--pid" option to save usbipd process id staging: usbip: set usbipd server port via "-t" / "--tcp-port" option. staging: usbip: properly handle "-l" / "--log" option staging: usbip: fix up alignment in long options list drivers/staging/usbip/userspace/src/usbip.c | 15 ++++-- drivers/staging/usbip/userspace/src/usbip_attach.c | 4 +- drivers/staging/usbip/userspace/src/usbip_list.c | 6 +-- .../staging/usbip/userspace/src/usbip_network.c | 30 +++++++++++ .../staging/usbip/userspace/src/usbip_network.h | 5 +- drivers/staging/usbip/userspace/src/usbipd.c | 61 +++++++++++++++++++--- 6 files changed, 101 insertions(+), 20 deletions(-) -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
