On Tue, 20 Aug 2013, Krzysztof Mazur wrote: > Ignoring usb_hub_create_port_device() errors cause later NULL pointer > deference when uninitialized hub->ports[i] entries are dereferenced > after port memory allocation error. > > Signed-off-by: Krzysztof Mazur <krzysiek@xxxxxxxxxxxx> > --- > I'm not sure if failing in that case is a good idea, but other solutions > are more complex. > > I tried also changing hdev->maxchild and skiping initialization > of later ports, but it didn't work because in some cases > hub->descriptor->bNbrPorts is used instead of hdev->maxchild. > With simulated usb_hub_create_port_device() failure I have an Oops > in hub_power_on(). I think this patch is correct. However, we also should change the other places that refer to bNbrPorts; make them use maxchild instead. > Another possible solution is allowing for uninitialized ports and > checking for hub->ports[i] == NULL. No, if we can't allocate memory for all the ports then the whole thing should fail. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
