On 5 August 2013 08:45, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: > control_selector_init() is used only in this file. > audio_bind_config() is used only in audio.c file to which > f_uac1.c is included. Thus, these functions are staticized > to fix the following warnings. > > drivers/usb/gadget/f_uac1.c:698:12: warning: symbol 'control_selector_init' was not declared. Should it be static? > drivers/usb/gadget/f_uac1.c:722:12: warning: symbol 'audio_bind_config' was not declared. Should it be static? > > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> Acked-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx> > --- > drivers/usb/gadget/f_uac1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/f_uac1.c b/drivers/usb/gadget/f_uac1.c > index fa8ea4e..2b4c82d 100644 > --- a/drivers/usb/gadget/f_uac1.c > +++ b/drivers/usb/gadget/f_uac1.c > @@ -695,7 +695,7 @@ static int generic_get_cmd(struct usb_audio_control *con, u8 cmd) > } > > /* Todo: add more control selecotor dynamically */ > -int __init control_selector_init(struct f_audio *audio) > +static int __init control_selector_init(struct f_audio *audio) > { > INIT_LIST_HEAD(&audio->cs); > list_add(&feature_unit.list, &audio->cs); > @@ -719,7 +719,7 @@ int __init control_selector_init(struct f_audio *audio) > * > * Returns zero on success, else negative errno. > */ > -int __init audio_bind_config(struct usb_configuration *c) > +static int __init audio_bind_config(struct usb_configuration *c) > { > struct f_audio *audio; > int status; > -- > 1.7.10.4 > > -- Linaro.org │ Open source software for ARM SoCs | Follow Linaro http://facebook.com/pages/Linaro/155974581091106 - http://twitter.com/#!/linaroorg - http://linaro.org/linaro-blog -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html