On Friday, August 02, 2013 4:38 PM, Felipe Balbi wrote:
> On Fri, Aug 02, 2013 at 04:33:12PM +0900, Jingoo Han wrote:
> > Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
> > build warning when CONFIG_PM_SLEEP is not selected. This is because
> > sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used
> > when the CONFIG_PM_SLEEP is enabled. Unnecessary CONFIG_PM ifdefs
> > are removed.
> >
> > drivers/usb/dwc3/dwc3-pci.c:215:12: warning: 'dwc3_pci_suspend' defined but not used [-Wunused-
> function]
> > drivers/usb/dwc3/dwc3-pci.c:224:12: warning: 'dwc3_pci_resume' defined but not used [-Wunused-
> function]
> >
> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> > ---
> > drivers/usb/dwc3/dwc3-pci.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> > index ed07ec0..abe91a9 100644
> > --- a/drivers/usb/dwc3/dwc3-pci.c
> > +++ b/drivers/usb/dwc3/dwc3-pci.c
> > @@ -211,7 +211,7 @@ static DEFINE_PCI_DEVICE_TABLE(dwc3_pci_id_table) = {
> > };
> > MODULE_DEVICE_TABLE(pci, dwc3_pci_id_table);
> >
> > -#ifdef CONFIG_PM
> > +#ifdef CONFIG_PM_SLEEP
> > static int dwc3_pci_suspend(struct device *dev)
> > {
> > struct pci_dev *pci = to_pci_dev(dev);
> > @@ -244,7 +244,7 @@ static const struct dev_pm_ops dwc3_pci_dev_pm_ops = {
> > #define DEV_PM_OPS (&dwc3_pci_dev_pm_ops)
> > #else
> > #define DEV_PM_OPS NULL
> > -#endif /* CONFIG_PM */
> > +#endif /* CONFIG_PM_SLEEP */
>
> if you're going to do this, we can get rid of the whole DEV_PM_OPS thing
> :-)
Hi Balbi,
Sorry, I cannot catch up with what you mean. :(
Then, is this patch not necessary?
Please, let me know what I should do. :)
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
