On Fri, Aug 02, 2013 at 11:30:54AM +0800, Ming Lei wrote: > On Fri, Aug 2, 2013 at 11:28 AM, Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Jul 03, 2013 at 10:53:07PM +0800, Ming Lei wrote: > >> 1), for drivers, they don't care if the complete() is called in hard irq > >> context or softirq context > > > > What about those 50+ patches you had that changed the locking for urb > > callbacks? Aren't they needed before this patch can go in? > > No, this patch has disabled interrupts already during complete(), so we > can reenable interrupts after all 50+ patches merged. Ok. > >> --- a/include/linux/usb/hcd.h > >> +++ b/include/linux/usb/hcd.h > >> @@ -22,6 +22,7 @@ > >> #ifdef __KERNEL__ > >> > >> #include <linux/rwsem.h> > >> +#include <linux/interrupt.h> > > > > Why is this .h file needed to be added here? > > For the introduced 'struct tasklet_struct'. Ah, I didn't realize it was in that .h file, ok, that makes sense. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
