On Thu, Aug 01, 2013 at 10:40:42AM +0200, Lothar Waßmann wrote:
> Hi,
>
> Peter Chen writes:
> > On Wed, Jul 31, 2013 at 04:21:15PM +0200, Lothar Waßmann wrote:
> > >
> > > Signed-off-by: Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx>
> > > ---
> > > drivers/usb/chipidea/core.c | 1 -
> > > 1 files changed, 0 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> > > index a5df24c..38b0a7a 100644
> > > --- a/drivers/usb/chipidea/core.c
> > > +++ b/drivers/usb/chipidea/core.c
> > > @@ -497,7 +497,6 @@ static int ci_hdrc_probe(struct platform_device *pdev)
> > > ret = ci_role_start(ci, ci->role);
> > > if (ret) {
> > > dev_err(dev, "can't start %s role\n", ci_role(ci)->name);
> > > - ret = -ENODEV;
> > > goto rm_wq;
> > > }
> > >
> >
> > +1, it can help get the error one time, without need to add the code
> > and get the error number from ci_role_start again.
> >
> I don't get what you mean.
>
For example, the ci_role_start returns error, the user can't
get error message directly, it can only get -ENODEV. If
the user wants to get what's error at ci_role_start, he
needs to add another debug message and re-compile the kernel.
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
