On Tue, Jul 30, 2013 at 09:49:05PM +0200, Frank Schäfer wrote:
> Based on the formula in the code description, Reinhard Max and me have
> investigated the devices behavior / functional principle of the divisor based
> baud rate encoding method.
>
> It turned out, that (although beeing a good starting point) the current code has
> some flaws. It doesn't work correctly for a wide range of baud rates and the
> divisor resolution can be improved. It also doesn't report the actually set baud
> rate.
Please wrap your changelog comments at 72 columns, it's just nice, and
what git asks you to do...
> This patch fixes and improves the code for the divisor based baud rate encoding
> method a lot. It can now be used for the whole range of baud rates from 46 baud
> to 24M baud with a very good divisor resolution and userspace can read back the
> resulting baud rate.
>
> It also documents the formula used for encoding and the hardware behavior
> (including special cases).
>
> The basic algorithm, rounding and several code comments/explanations are
> provided by Reinhard Max.
> I've added some minor fixes, the handling of the special cases and further
> code/algorithm descriptions.
>
> Signed-off-by: Frank Schäfer <fschaefer.oss@xxxxxxxxxxxxxx>
> Signed-off-by: Reinhard Max <max@xxxxxxx>
> ---
> drivers/usb/serial/pl2303.c | 59 +++++++++++++++++++++++++++++++++++--------
> 1 Datei geändert, 49 Zeilen hinzugefügt(+), 10 Zeilen entfernt(-)
>
> diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
> index 2448201..323dfa6 100644
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -3,6 +3,8 @@
> *
> * Copyright (C) 2001-2007 Greg Kroah-Hartman (greg@xxxxxxxxx)
> * Copyright (C) 2003 IBM Corp.
> + * Copyright (C) 2009, 2013 Frank Schäfer <fschaefer.oss@xxxxxxxxxxxxxx>
> + * Copyright (C) 2013 Reinhard max <max@xxxxxxx>
Interesting.
I see Frank contributed back in 2009, which is fine.
But the "rules" for copyright on an existing file are generally well
known by people, and this patch doesn't cover that type of definition as
far as I can tell[1], so I'm not allowed to add these copyright lines to
the file, sorry :(
And you forgot to upper-case the last letter of your name :)
So, can you please resend this series, starting here (I've applied your
first patch), after fixing this up, and the changelog changes as I've
pointed out above, and the other comment you got on this series?
thanks,
greg k-h
[1] You need to have "created/modified" at least 1/3 of a file to be
considered a copyright owner in almost all jurisdictions that I know
of. If you don't do that, I have been advised by my lawyer that I
can not add a copyright notice to a file. If you disagree with
this, that's great, please have your IP lawyer contact me and I will
be glad to discuss it with them.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
