Hello. On 07/31/2013 10:48 PM, Sarah Sharp wrote:
Add Device Tree match table to xhci-plat.c. Add DT bindings document.
Signed-off-by: Al Cooper <alcooperx@xxxxxxxxx> ---
Al, in the future, please add a description of your changes since the last revision here, after the --- line. It makes it much easier to review patch revisions.
Yes, please do.
Documentation/devicetree/bindings/usb/usb-xhci.txt | 14 ++++++++++++++ drivers/usb/host/xhci-plat.c | 10 ++++++++++ 2 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/usb-xhci.txt
diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt new file mode 100644 index 0000000..5752df0 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt @@ -0,0 +1,14 @@ +USB xHCI controllers
Ok, Sergei's comment was addressed.
+ +Required properties: + - compatible: should be "xhci-platform". + - reg: should contain address and length of the standard XHCI + register set for the device. + - interrupts: one XHCI interrupt should be described here. + +Example: + usb@f0931000 {
Also addressed.
+ compatible = "xhci-platform";
You didn't take Sergei's suggestion to change this to usb-xhci-platform.
No, I didn't really suggest this. I suggested keeping "usb-xhci" (or maybe using "snps,xhci" if this is for Synopsis IP like Felipe said).
That's not specific to the IP, so it doesn't violate the DT rules, but
The "compatible" property can be specific to IP. It's the node name that can't.
it also lets people know which subsystem xHCI belongs to.
Did you have a strong reason to keep it as xhci-platform, rather than changing it to usb-xhci-platform?
Sergei, Felipe, do you have a strong preference on this name? Or should I take the patch as is?
I've already said I don't have a strong preference. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
