On Wed, Jul 31, 2013 at 11:49 PM, Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote: > On Wed, Jul 31, 2013 at 5:56 PM, Till Schmalmack <till@xxxxxxxxxxxxxx> wrote: >> Hello Ming, >> >> I am experiencing issues with the usbnet commits you did for the 3.10 >> kernel, in particular with >> >> 4be74c13 usbnet: mcs7830: apply usbnet_link_change >> >> I filed this bug >> >> https://bugzilla.kernel.org/show_bug.cgi?id=60662 > > Thanks for the report. > > Looks you didn't provide any debug info, could you apply the attachment > patch and post the 'dmesg' info when you reproduce the bug. Also I am wondering the commit 4be74c13(usbnet: mcs7830: apply usbnet_link_change) may cause the regression. If you look at commit 4be74c13(usbnet: mcs7830: apply usbnet_link_change) and commit ac64995da(usbnet: introduce usbnet_link_change API), you may find basically no real code changes on msc7830 drivers, and only the below code is moved into usbnet_link_change() from mcs7830_status, isn't it? if (link) netif_carrier_on(dev->net); else netif_carrier_off(dev->net); Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html