Re: [PATCH] musb: don't reset endpoint data toggle on blackfin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Jul 31, 2013 at 06:26:24PM +0800, Scott Jiang wrote:
> >> > On Thu, Jul 18, 2013 at 07:04:14PM -0400, Scott Jiang wrote:
> >> >> Reset endpoint data toggle would lead to failure for musb
> >> >> RTL version 1.9 on blackfin.
> >> >
> >> > is this specific to musb 1.9 or to blackfin ?
> >> >
> >> I'm not sure about this. It failed in musb 1.9 on bf527.
> >> But this bug didn't affect musb RTL 2.0 on bf609.
> >
> > Do you have Mentor's errata list or just Analog Device's errata ?
> 
> I reviewed the Analog Device's errata but it didn't mention this. I'd keep
> this as a local patch because I can't test it on other platform. Thanks.

alright. I'd like to push it upstream, but perhaps we add a quirk
flag and enable it for blackfin only ? Can you do that ?

Add a 'quirks' member to struct musb and struct musb_platform_data, then
pass the quirks from blackfin.c to MUSB. If other people need th
workaround, they just add the flag.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux