Re: [PATCH V3] usb: Add Device Tree support to XHCI Platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 07/23/2013 06:35 PM, Matthijs Kooijman wrote:

@@ -212,11 +213,19 @@ static int xhci_plat_remove(struct platform_device *dev)
  	return 0;
  }

+#ifdef CONFIG_OF
+static const struct of_device_id usb_xhci_of_match[] = {
+	{ .compatible = "usb-xhci" },
+	{},
+};

   I wonder if we also need:

MODULE_DEVICE_TABLE(of, usb_xhci_of_match);

+#endif
+
  static struct platform_driver usb_xhci_driver = {
  	.probe	= xhci_plat_probe,
  	.remove	= xhci_plat_remove,
  	.driver	= {
  		.name = "xhci-hcd",
+		.of_match_table = of_match_ptr(usb_xhci_of_match),
  	},
  };
  MODULE_ALIAS("platform:xhci-hcd");

This looks like it wouldn't compile without CONFIG_OF?

   No, of_match_ptr() is #defined to NULL when CONFIG_OF=n.

Gr.

Matthijs

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux