On Fri, Jul 19, 2013 at 10:42:50PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 07/19/2013 02:40 AM, Sergei Shtylyov wrote:
>
> >>Add Device Tree match table. Setup dma_mask and coherent_dma_mask
> >>if they're not already set.
>
> >>Signed-off-by: Al Cooper <alcooperx@xxxxxxxxx>
> >[...]
>
> >>@@ -186,11 +198,17 @@ static int xhci_plat_remove(struct platform_device *dev)
> >> return 0;
> >> }
> >>
> >>+static const struct of_device_id usb_xhci_of_match[] = {
> >>+ { .compatible = "xhci-hcd" },
>
> > I think just "xhci" would be enough. We're describing the device, not its
> >driver with this prop.
>
> BTW, you need to describe the xHCI DT binding somewhere in
> Documentation/devicetree/bindings/usb/ in the same patch.
>
> PS: Sarah, sorry for commenting on xHCI patches, I hope my comments
> were more to the point this time. :-)
Yes, they were appropriate. Thank you for increasing your signal to
noise ratio. :)
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
