On Thursday 18 July 2013 11:54 AM, Greg KH wrote: > On Thu, Jul 18, 2013 at 11:33:17AM +0530, Kishon Vijay Abraham I wrote: >>>> Wanted to group all the PHY drivers to be used by different subsystems >>>> (SATA/USB/PCIE/HDMI/VIDEO) into a single entity. There were some comments in my >>>> initial version [3] on using a bus_type instead of class but then it was >>>> decided to go with class itself. >>>> >>>> [3] -> http://lkml.indiana.edu/hypermail/linux/kernel/1302.2/01389.html >>> >>> Ok, but what does the class usage get you? >> >> hmm.. actually I use class only to iterate through the list of devices in *phy* >> class which could very well be implemented using list. Just that I wont have a >> /sys/class/phy/ entry to find the list of phys added in the system. I dont >> think I want to add any other stuff to expose to the user space at this point >> of time. >>> >>>>> When modifying/adding new sysfs stuff, you need a Documentation/ABI/ >>>>> entry as well. >>>> >>>> I'm not actually adding any new sysfs entry other than what a *class_create* >>>> must have created. Do I need to add one for that? >>> >>> If you are not creating anything in sysfs at all, why use the driver >>> model? (hint, I think you need to do something here to justify it...) >> >> Well.. it helps me to use pm_runtime to enable clocks utilizing the >> parent-child relationship. > > Ok, that's a good reason for this, nevermind then. Care to send the > latest patches you have in emails so I can review them? Sure. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
