On Tue, Jul 16, 2013 at 08:30:21PM +0200, Daniel Mack wrote: > On 16.07.2013 20:26, Aaro Koskinen wrote: > > Hi, > > > > On Tue, Jul 16, 2013 at 11:22:47AM +0300, Felipe Balbi wrote: > >>> On Tue, Jul 16, 2013 at 12:30:00PM +0530, Kishon Vijay Abraham I wrote: > >>>> On Tuesday 16 July 2013 12:03 PM, Daniel Mack wrote: > >>>>> Hi Aaro, > >>>>> > >>>>> On 16.07.2013 00:56, Aaro Koskinen wrote: > >>>>>> Hi, > >>>>>> > >>>>>> I think USB tree introduced regressions in v3.11-rc1, at least for some > >>>>>> OMAP devices using legacy boot. > >>>>> > >>>>> Thanks for checking the tree so early. > >>>>> > >>>>>> I have only bisected these; I have no > >>>>>> idea what the real fixes are but the following reverts make Nokia OMAP2+ > >>>>>> boards again usable for kernel development work (they need working USB > >>>>>> connection for interacting with the device): > >>>>>> > >>>>>> 1) USB peripheral mode (g_ether) is broken on Nokia N900, N950 and N9 > >>>>>> (USB_MUSB_OMAP2PLUS). To make it it work, I need to revert three > >>>>>> commits: > >>>>>> > >>>>>> 09fc7d22b024692b2fe8a943b246de1af307132b > >>>>>> usb: musb: fix incorrect usage of resource pointer > >>>>>> (Reverting this fixes the g_ether probe failure "couldn't find > >>>>>> an available UDC") > >>>> > >>>> I've posted a patch fixing the issue > >>>> http://comments.gmane.org/gmane.linux.usb.general/89541 > >>>> There were some comments on it. I'll be posting a new version for it. > >>> > >>> hmm, n8x0 used tusb6010, so perhaps a similar patch needs to be cooked > >>> for that too. Right now, let's to the minimum fix, which is just to > >>> increment the array size to 3 and for v3.12 we do the changes that I > >>> suggested. > >> > >> this should solve the problem on n900 and n8x0, it's pretty much > >> kishon's original patch, so I guess it deserves his authorship: > > > > Thanks, and yes it fixes this issue. I tested both N900 and N800, so > > feel free to add my Tested-by. > > Together with my patch I take it? Does your Tested-by apply to this one > as well? I tested also that one (ARM: omap2: fix musb usage for n8x0), so yes, it's for both patches. A. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
