On Tue, 16 Jul 2013, Andrzej Pietrasiewicz wrote:
> When configfs is in place, the things related to intialization
> of struct fsg_common will be split over a number of places.
> This patch adds several functions which together cover the former
> intialization routine fsg_common_init. As a consequence, issuing of
> some debug messages needs to be adjusted.
> --- a/drivers/usb/gadget/storage_common.c
> +++ b/drivers/usb/gadget/storage_common.c
> @@ -179,7 +179,7 @@ EXPORT_SYMBOL(fsg_ss_function);
> void fsg_lun_close(struct fsg_lun *curlun)
> {
> if (curlun->filp) {
> - LDBG(curlun, "close backing file\n");
> + pr_debug("close backing file\n");
Here and in lots of other places, you have replaced a log message that
includes the LUN's name and driver with a message that includes
neither. If somebody reads the system log after this change, how are
they going to know _which_ LUN had its backing file closed? That
information should be included in the message.
Why not just change the definitions of LDBG, LINFO, and so on instead
of changing all the places where they get called?
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
