Re: [PATCH 1/2] usb: chipidea: kconfig: using USB_EHCI_HCD instead of USB for dependency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 8, 2013 at 3:42 PM, Peter Chen <peter.chen@xxxxxxxxxxxxx> wrote:
> Chipidea controller is an EHCI compatible controller, with current
> kconfig, even CONIFG_USB_EHCI_HCD is not chosen, but CONFIG_USB
> is there, the chipidea code still will be compiled, in fact, it
> is useless.
>
> Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> ---
>  drivers/usb/chipidea/Kconfig |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig
> index d1bd8ef..f257eb6 100644
> --- a/drivers/usb/chipidea/Kconfig
> +++ b/drivers/usb/chipidea/Kconfig
> @@ -1,6 +1,6 @@
>  config USB_CHIPIDEA
>         tristate "ChipIdea Highspeed Dual Role Controller"
> -       depends on USB || USB_GADGET
> +       depends on USB_EHCI_HCD || USB_GADGET
>         help
>           Say Y here if your system has a dual role high speed USB
>           controller based on ChipIdea silicon IP. Currently, only the
> @@ -19,7 +19,6 @@ config USB_CHIPIDEA_UDC
>
>  config USB_CHIPIDEA_HOST
>         bool "ChipIdea host controller"
> -       depends on USB=y
>         depends on USB_EHCI_HCD=y || (USB_CHIPIDEA=m && USB_EHCI_HCD=m)
>         select USB_EHCI_ROOT_HUB_TT
>         help
> --
> 1.7.0.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

ping...

Alex, any comments for these two patches?

--
BR,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux