Re: [PATCH 03/50] USB: usblp: spin_lock in complete() cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 11, 2013 at 11:33 PM, Pete Zaitcev
<zaitcev@xxxxxxxxxxxxxxxxx> wrote:
> On Thu, 11 Jul 2013 17:05:26 +0800
> Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote:
>
>> Complete() will be run with interrupt enabled, so change to
>> spin_lock_irqsave().
>>
>> Cc: Pete Zaitcev <zaitcev@xxxxxxxxxx>
>> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>
>
> Signed-off-by: Pete Zaitcev <zaitcev@xxxxxxxxxxxxxxxxx>

Thank you.

> Good luck with that, Ming. I think the spin_lock_irqsave thing should've
> been done back in days of uhci-hcd. But we always had some super annoying
> edge cases when we considered it previously. I see Alan Stern signed off
> the HCD changes at the beginning of July, so you're on the right track.
>
> BTW, perfect formatting in usblp.c, too bad for Sergei's heartburn ^_^
>
> -- Pete
>
> P.S. Is it just me, or you forgot to fix usb-skeleton.c in your 50
> patches?

It is my script which ignored the top directory of drivers/usb,  :-)
and I will add it in the next round, thanks for pointing it out.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux