Minor coding style nits below: On Fri, Jul 12, 2013 at 03:36:27AM +0300, Xenia Ragiadakou wrote: > --- a/drivers/usb/host/xhci-dbg.c > +++ b/drivers/usb/host/xhci-dbg.c > @@ -21,6 +21,7 @@ > */ > > #include "xhci.h" > +#include "xhci-trace.h" > > #define XHCI_INIT_VALUE 0x0 > > @@ -580,3 +581,16 @@ void xhci_dbg_ctx(struct xhci_hcd *xhci, > xhci_dbg_slot_ctx(xhci, ctx); > xhci_dbg_ep_ctx(xhci, ctx, last_ep); > } > + > +void xhci_dbg_address(struct xhci_hcd *xhci, const char *fmt, ...) > +{ > + struct va_format vaf; > + va_list args; > + > + va_start(args, fmt); > + vaf.fmt = fmt; > + vaf.va = &args; > + xhci_dbg(xhci, "%pV", &vaf); > + trace_xhci_dbg_address(&vaf); > + va_end(args); You forgot to run your patch through checkpatch.pl :) > --- /dev/null > +++ b/drivers/usb/host/xhci-trace.c > @@ -0,0 +1,21 @@ > +/* > + * xHCI host controller driver > + * > + * Author: Ksenia Ragiadakou Email address here please. Actually, it should have your copyright, not just "Author:". > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY > + * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > + * for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software Foundation, > + * Inc., 675 Mass Ave, Cambridge, MA 02139, USA. We don't want to track the office of the FSF for the next 40+ years, so both of these two paragraphs can be removed (we all know what the GPL is.) > + */ > + > +#define CREATE_TRACE_POINTS > +#include "xhci-trace.h" > diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h > new file mode 100644 > index 0000000..a3e9ca3 > --- /dev/null > +++ b/drivers/usb/host/xhci-trace.h > @@ -0,0 +1,55 @@ > +/* > + * xHCI host controller driver > + * > + * Author: Ksenia Ragiadakou > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY > + * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > + * for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software Foundation, > + * Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > + */ Same comments here as above. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html