Re: [PATCH v4 3/5] USB: EHCI: improve ehci_endpoint_disable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2 Jul 2013, Ming Lei wrote:

> The patch does the below improvement:
> 
> - think QH_STATE_COMPLETING as unlinking state since all URBs on the
> endpoint should be in unlinking or unlinked when doing endpoint_disable()
> 
> - add "WARN_ON(!list_empty(&qh->qtd_list));" if qh->qh_state is
> QH_STATE_LINKED because there shouldn't be any active transfer in qh
> 
> - when qh->qh_state is QH_STATE_LINKED, the QH(async or periodic)
> should be in its corresponding list, so the search through the async
> list isn't necessary.
> 
> - unlink periodic QH to speed up unlinking if the QH is in linked
> state
> 
> Basically, only the last one is related with this patchset because
> the assumption of "periodic qh self-unlinks on empty" isn't true
> any more when we introduce unlink-wait for periodic qh.
> 
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux