On Mon, Jul 01, 2013 at 04:56:22AM +0300, Xenia Ragiadakou wrote: > Yes, you are right. What about removing entirely the dma_mask > setup code from xhci_gen_setup() and let the dma_mask setup > to be handled in xhci_pci_setup() and xhci_plat_setup() accordingly? > > I suggest that because, for pci platforms since both dma_mask > and dma_coherent_mask is already initialized to 32 bits, we don't > need to set them again if dma_set_mask(dev, DMA_BIT_MASK(64)) > fails or to check if dma_mask is uninitialized. > And for non-pci platforms, if dma_mask=&coherent_dma_mask, > we will only need to set the dma_mask and not both. Sure, that approach makes sense. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
